Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contents of symlinked directories in fileset #483

Merged
merged 2 commits into from
Jul 29, 2016

Conversation

svdm
Copy link
Contributor

@svdm svdm commented Jul 25, 2016

See #481

I've included a snapshot version bump, but I can of course remove that if desired.

svdm added 2 commits July 25, 2016 11:13
Symlinked directories present in e.g. source-paths were previously
ignored when building the fileset because the relevant tree-walking
functions ignored links. By enabling them to follow symlinks, the
contents of linked directories are now included in the fileset.

Note that the symlinked directories are synced into "real" directories
in the temp dir. For example, a symlink `foo` that points to a directory
containing `bar.clj`, will be present in the temp dir as a *plain*
directory `foo` containing `bar.clj`. So once these symlinked
directories have been added to the fileset, they behave exactly as a
plain directory would (because they are one). As a bonus, this means the
change has no effect on any further temp dir related filesystem interaction
(like scary deletion/cleanup that could interact with symlinks).

Fixes boot-clj#481.
@micha micha added this to the 2.6.1 milestone Jul 29, 2016
@micha micha merged commit c32bc69 into boot-clj:master Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants