Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't limit true values to "1" or "yes" #631

Closed
xiongtx opened this issue Jul 19, 2017 · 1 comment
Closed

Don't limit true values to "1" or "yes" #631

xiongtx opened this issue Jul 19, 2017 · 1 comment

Comments

@xiongtx
Copy link

xiongtx commented Jul 19, 2017

Boot Bug Report

Platform details

Platform (macOS, Linux, Windows): Darwin C02RW05YFVH6 15.6.0
JRE/JDK version (java -version):

java version "1.8.0_102"
Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)

Boot details

BOOT_CLOJURE_NAME=org.clojure/clojure
BOOT_CLOJURE_VERSION=1.7.0
BOOT_VERSION=2.6.0

Description

Boot requires a number of environment variables, e.g. BOOT_WATCHERS_DISABLE, to be 1 or yes. This is arbitrary and contrary to expectation--we recently ran into an issue where BOOT_WATCHERS_DISABLE wasn't working because we had set it to true, a much more common and conventional value.

These environment variables should accept any truthy value, e.g. true, and reject only some values, e.g. false.

Steps to reproduce

  1. Set BOOT_WATCHERS_DISABLE to true in circle.yml
  2. Be confused as to why it's not working on CircleCI
@arichiardi
Copy link
Contributor

I agree there is a problem with that there, but we should follow some convention, not pick arbitrary things and || them together.

For instance one could pick the following convention: when the variable is set it means the "feature" is enabled, no matter what value. But this is only one possible solution.

Probably the picked convention should be really clear in the env var documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants