Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to resources are not seen when using sift in 2.8.0 #704

Closed
borkdude opened this issue Jun 26, 2018 · 4 comments
Closed

Changes to resources are not seen when using sift in 2.8.0 #704

borkdude opened this issue Jun 26, 2018 · 4 comments

Comments

@borkdude
Copy link

borkdude commented Jun 26, 2018

Problem Description

Boot development task that worked in 2.7.2 now has problem: changes to resources are not seen anymore.

E.g. when I (slurp (io/resource "issue/core.clj")) and then edit core.clj and evaluate (slurp (io/resource "issue/core.clj")) again, it doesn't see the changes. This is somehow related to the sift task. If I uncomment this line https://github.com/borkdude/boot-sift-issue/blob/master/build.boot#L33 then it works in 2.8.0. It worked in 2.7.2.

Why do I need this to work:
I need to see changes to resources, because I load queries from .sql files using HugSQL.
E.g.

(hugsql/def-db-fns "dre/db/html/query.sql" {:quoting :ansi})

When I change query.sql I want to be able to re-eval that expression and use the new queries.

Steps to reproduce

Reproducible example:

https://github.com/borkdude/boot-sift-issue/tree/master

Platform details

Platform (macOS, Linux, Windows): macOS
Platform version: High Sierra
JRE/JDK version (java -version): "1.8.0_45"

Boot details

Boot version: 2.8.0
build.boot present? (yes/no): yes
~/.boot/profile present? (yes/no): no
Task name? (if applicable): dev/sift

Please also provide the contents of build.boot and ~/.boot/profile (if applicable).

See: https://github.com/borkdude/boot-sift-issue/tree/master

@alandipert
Copy link
Contributor

This is because of #680 which went out with 2.8.0.

We need to decide if we want to keep the change, and there is a suitable alternate workflow, or if we want to revert the change.

@alandipert
Copy link
Contributor

Reverted #680 and pushing 2.8.1 so we can discuss further how we want to proceed.

@arichiardi
Copy link
Contributor

Yep this is due to the behavior change - watch+sift is not eager anymore with that patch it seems, haven't investigated further though /cc @bhagany

@alandipert
Copy link
Contributor

@borkdude did 2.8.1 fix this for you? (Even though it broke call?) If so please feel free to close ticket.

@borkdude borkdude closed this as completed Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants