Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaped chars in string produces illegal result #35

Closed
andelf opened this issue Sep 15, 2023 · 7 comments
Closed

Escaped chars in string produces illegal result #35

andelf opened this issue Sep 15, 2023 · 7 comments

Comments

@andelf
Copy link

andelf commented Sep 15, 2023

(print (str (borkdude.rewrite-edn/assoc (borkdude.rewrite-edn/parse-string "{}") :a "C+\\")))
;; produces
{:a "C+\"}
;; which is invalid value

See-also: logseq/logseq#10218

@borkdude
Copy link
Owner

I think this is due to a rewrite-clj issue:

user=> (println (str (rewrite-clj.node/coerce "C+\\")))
"C+\"

@borkdude
Copy link
Owner

Bumping rewrite-clj to 1.1.47 seems to fix it.

@borkdude
Copy link
Owner

How are you using rewrite-edn in logseq, in a JVM, CLJS or (n)bb?

@andelf
Copy link
Author

andelf commented Sep 15, 2023

It's used as CLJS.

@borkdude
Copy link
Owner

Alright, bumping rewrite-clj in your project should fix this then.

@andelf
Copy link
Author

andelf commented Sep 15, 2023

Many thanks.

@borkdude
Copy link
Owner

Released as 0.4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants