[PDB-02S] Inexistent Sanitization of Input Address

[zajck]

PDB-02S: Inexistent Sanitization of Input Address

Type	Severity	Location
Input Sanitization		PriceDiscoveryBase.sol:L39-L42

Description:

The linked function accepts an address argument yet does not properly sanitize it.

Impact:

The presence of zero-value addresses, especially in constructor implementations, can cause the contract to be permanently inoperable. These checks are advised as zero-value inputs are a common side-effect of off-chain software related bugs.

Example:

constructor(address _wNative, uint256 _firstExchangeId2_2_0) {
    wNative = IWrappedNative(_wNative);
    EXCHANGE_ID_2_2_0 = _firstExchangeId2_2_0;
}

Recommendation:

We advise some basic sanitization to be put in place by ensuring that the address specified is non-zero.