Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLB-02C] Repetitive Value Literal #869

Closed
zajck opened this issue Jan 8, 2024 · 0 comments · Fixed by #881
Closed

[FLB-02C] Repetitive Value Literal #869

zajck opened this issue Jan 8, 2024 · 0 comments · Fixed by #881
Assignees
@zajck
Labels
Refactor v2.4.0

Comments

@zajck
Copy link
Member

zajck commented Jan 8, 2024

FLB-02C: Repetitive Value Literal

Type Severity Location
Code Style FundsLib.sol:L260, L275, L281, L321, L323, L344, L565, L568, L584

Description:

The linked value literal is repeated across the codebase multiple times.

Example:

effectivePriceMultiplier = 10000;

Recommendation:

We advise it to be set to a constant variable instead optimizing the legibility of the codebase.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zajck zajck

Labels
Refactor v2.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FLB-02C] Repetitive Value Literal bosonprotocol/boson-protocol-contracts
1 participant
@zajck