-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installation from git is broken #429
Comments
See https://github.com/botify-labs/simpleflow/blob/main/pyproject.toml#L86C2-L88 and https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html . We're missing |
Thanks @ewjoachim I just saw exactly that! For posterity:
I'll check everything twice and submit a PR this morning |
Oopsie—I've been bitten by this a few times but didn't investigate it; thank you both! |
The issue is that as soon as I include all sub directories correctly, I get "build", "examples", "venv" and "tests" installed into my site-packages. The "exclude" directive doesn't seem to work, at least not as documented. I'm digging more. Send help if you don't hear about me in 2 days. |
@ybastide @ewjoachim I randomly stumbled upon Hatch via Stackoverflow, and it works nicely out of the box. I'm tempted to dig into that direction, and in particular check if it has any impact on "script/release". Any opinion on the topic? |
Looks like it would simplify |
Not a huge fan of hatch compared to poetry (both are equivalent tools) but it's true that hatch, being born later, uses the standard PEP-defined format for pyproject.toml while poetry uses its own format. Honnestly, I'm ok with both. |
Alternatively we can keep setuptools if we find a config that works (== that doesn't leak "examples" in my site-packages 😆) About poetry: I'm using it daily and I absolutely hate it. It failed us so many times (not in the context of a lib though). I'd be very happy to discuss this with you over a beer one day! |
👎 on keeping setuptools, we all want to learn 🙂 |
@ybastide @ewjoachim I tested hatch a bit more and submitted a PR here => #435. Lmk what you think, no hurry! |
Problem:
results in:
We're missing all the subdirectories.
Versions in case it matters:
I'm digging
The text was updated successfully, but these errors were encountered: