From e2475e83d681a8f6d6cae548de243d93dec0b520 Mon Sep 17 00:00:00 2001
From: Alessandra Romero <romero.alessandra1@gmail.com>
Date: Thu, 22 Aug 2024 10:26:33 -0400
Subject: [PATCH] update parser test with known invalid expires test cases

---
 tests/unit/test_parsers.py | 48 +++++++++++++++++++++-----------------
 1 file changed, 27 insertions(+), 21 deletions(-)

diff --git a/tests/unit/test_parsers.py b/tests/unit/test_parsers.py
index 039a4f6397..4dc11088f0 100644
--- a/tests/unit/test_parsers.py
+++ b/tests/unit/test_parsers.py
@@ -1641,10 +1641,10 @@ def setUp(self):
         )
 
     def test_valid_expires_response_parsed(self):
-        expires_value = 'Thu, 01 Jan 2015 00:00:00 GMT'
+        expires = 'Thu, 01 Jan 2015 00:00:00 GMT'
         parsed = self.parser.parse(
             {
-                'headers': {'Expires': expires_value},
+                'headers': {'Expires': expires},
                 'body': b'',
                 'status_code': 200,
             },
@@ -1653,31 +1653,37 @@ def test_valid_expires_response_parsed(self):
         expected = {
             'ResponseMetadata': {
                 'HTTPStatusCode': 200,
-                'HTTPHeaders': {'expires': expires_value},
+                'HTTPHeaders': {'expires': expires},
             },
             'Expires': datetime.datetime(2015, 1, 1, tzinfo=tzutc()),
-            'ExpiresString': expires_value,
+            'ExpiresString': expires,
         }
         self.assertEqual(parsed, expected)
 
     def test_invalid_expires_response_parsed(self):
-        expires_value = 'Invalid-Date'
-        parsed = self.parser.parse(
-            {
-                'headers': {'Expires': expires_value},
-                'body': b'',
-                'status_code': 200,
-            },
-            self.output_shape,
-        )
-        expected = {
-            'ResponseMetadata': {
-                'HTTPStatusCode': 200,
-                'HTTPHeaders': {'expires': 'Invalid-Date'},
-            },
-            'ExpiresString': expires_value,
-        }
-        self.assertEqual(parsed, expected)
+        invalid_expires_values = """\
+        Invalid Date
+        access plus 1 month
+        Expires: Thu, 9 Sep 2013 14:19:41 GMT
+        {ts '2023-10-10 09:27:14'}
+        """
+        for expires in invalid_expires_values.splitlines():
+            parsed = self.parser.parse(
+                {
+                    'headers': {'Expires': expires},
+                    'body': b'',
+                    'status_code': 200,
+                },
+                self.output_shape,
+            )
+            expected = {
+                'ResponseMetadata': {
+                    'HTTPStatusCode': 200,
+                    'HTTPHeaders': {'expires': expires},
+                },
+                'ExpiresString': expires,
+            }
+            self.assertEqual(parsed, expected)
 
 
 class TestS3ParseShapes(unittest.TestCase):