Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split credentials-providing/config into separate package #2842

Closed
2 tasks
thejcannon opened this issue Dec 29, 2022 · 4 comments
Closed
2 tasks

Split credentials-providing/config into separate package #2842

thejcannon opened this issue Dec 29, 2022 · 4 comments
Assignees
Labels
duplicate This issue is a duplicate. feature-request This issue requests a feature.

Comments

@thejcannon
Copy link

Describe the feature

Split the config/credential loading into a seperate package.

Use Case

I have an application-case for loading credentials for s3, but not actually using botocore's S3 support (instead using the creds to presign a HTTP url). The latest botocore whl (1.29.39) is ~72.5MB extracted, so pulling in all of botocore for this is certainly not ideal

Proposed Solution

Similar to Rusts' aws-config which is scoped to config-specific code (which also has the added benefit of the compiler ignoring unused code 😅 ), a dedicated package for config/credential loading.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

SDK version used

N/A

Environment details (OS name and version, etc.)

N/A

@thejcannon thejcannon added feature-request This issue requests a feature. needs-triage This issue or PR still needs to be triaged. labels Dec 29, 2022
@thejcannon
Copy link
Author

thejcannon commented Dec 29, 2022

On further inspection it looks like about 70MB out of that 72.5MB is just the data/ directory. 🤯

I'm sure there's options here. One could be to split each service into an individual package (e.g. botocore-a-la-carte-s3, etc...). botocore-a-la-carte would contain core code with an extra per service (e.g. botocore-a-la-carte[s3, cloudfront]) and to maintain backwards-compatibility botocore would simply be botocore-a-la-carte[all].

@tim-finnigan tim-finnigan self-assigned this Dec 29, 2022
@tim-finnigan
Copy link
Contributor

Hi @thejcannon thanks for reaching out. This appears to overlap with #2365. Some ideas were proposed there for addressing the expanding size of schemas. The team plans to work on this issue but there are no other updates for now. For consolidation purposes I think we should continue using #2365 to track this.

@tim-finnigan tim-finnigan added duplicate This issue is a duplicate. closing-soon and removed needs-triage This issue or PR still needs to be triaged. labels Dec 29, 2022
@thejcannon
Copy link
Author

👋 Thanks for the speedy response!

I think more honestly I'd call it a duplicate of #1543 since I don't need any services just to access credentials.

@thejcannon
Copy link
Author

(I'll close it either way, let the bot take the day off)

@thejcannon thejcannon closed this as not planned Won't fix, can't repro, duplicate, stale Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue is a duplicate. feature-request This issue requests a feature.
Projects
None yet
Development

No branches or pull requests

2 participants