feat(jex): more unit tests + no more throwing when parsing json-schema #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmass
approved these changes
Oct 17, 2024
franklevasseur
commented
Oct 17, 2024
| @@ -2,67 +2,61 @@ import { JSONSchema7 } from 'json-schema' | |||
| import { test, expect } from 'vitest' | |||
| import { JexIR } from './typings' | |||
| import { fromJsonSchema as j2x } from './from-json-schema' | |||
| import { jexEquals as jexEquals } from '../jex-equals' | |||
There was a problem hiding this comment.
note: I wanted to make this test suite more unit or isolated. So I removed usage of jexEquals which is tested on its own
jex/src/jexir/from-json-schema.ts
Outdated
There was a problem hiding this comment.
note: Instead of throwing when mapping from json-schema to jexir-schema, I decided to fallback to unknown, when I can't handle a situation
| let jexA = await jexir.fromJsonSchema(a) | ||
| let jexB = await jexir.fromJsonSchema(b) | ||
| jexA = jexir.normalize(jexA) | ||
| jexB = jexir.normalize(jexB) | ||
| return jexExtends(jexA, jexB) | ||
| } | ||
|
|
||
| export const jsonSchemaMerge = async (a: JSONSchema, b: JSONSchema): Promise<JSONSchema> => { |
There was a problem hiding this comment.
note: I don't remember the purpose of this function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on intersections, and I realized I had a lot of unrelated changes and refactors so I opened this intermediate PR