Add option to deregister node before draining. #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
reviewed
Aug 10, 2022
somnusfish
force-pushed
the
deregister
branch
4 times, most recently
from
d8f5148
to
a9d074f
Compare
|
Address the comments with name change and updated readme.md. |
cbgbt
reviewed
Aug 12, 2022
README.md
Outdated
Comment on lines
38
to
39
| To enable this feature, go to `.env`, change `EXCLUDE_FROM_LB_WAIT_TIME_IN_SEC` to a positive integer value, | ||
| run `cargo build` to regenerate `bottlerocket-update-operator.yaml` and follow the normal installation guideline. |
There was a problem hiding this comment.
I think instead of directing folks to rebuild the project, we should have folks modify the .yaml document describing the pod deployment to modify the environment variable.
When we begin delivering this as a Helm chart, we can make that variable configurable via Helm.
There was a problem hiding this comment.
Updated readme using .yaml for user. I would like to have a separate PR to update the development part.
* Exclude node from load balancer before draining when EXCLUDE_FROM_LB_WAIT_TIME_IN_SEC is larger than 0. * Remove node exclusion from load balancer after draining when EXCLUDE_FROM_LB_WAIT_TIME_IN_SEC is larger than 0.
cbgbt
approved these changes
Aug 16, 2022
gthao313
approved these changes
Aug 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
#156
Description of changes:
DEREGISTER_FROM_LB_WAIT_TIME_IN_SECin.envas environment variable.when DEREGISTER_FROM_LB_WAIT_TIME_IN_SEC is larger than 0.
when DEREGISTER_FROM_LB_WAIT_TIME_IN_SEC is larger than 0.
Testing done:
Tested on cluster, monitored node get labeled and unlabeled.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.