Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy warnings #267

Merged
merged 5 commits into from
Oct 5, 2022
Merged

Conversation

jpculp
Copy link
Member

@jpculp jpculp commented Oct 4, 2022

Testing done:

Updated small group of 3 bottlerocket nodes. (thanks, @gthao313!)

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jpculp
Copy link
Member Author

jpculp commented Oct 4, 2022

Rebased to see if it fixes the CI issue.

@stmcginnis
Copy link
Contributor

Rebased to see if it fixes the CI issue.

Maybe the runner has a different rust version than your local version?

Run rustup update stable
  rustup update stable
  shell: /usr/bin/bash -e {0}
info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu'

info: checking for self-updates
  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.64.0 (a55dd71d5 [2](https://github.com/bottlerocket-os/bottlerocket-update-operator/actions/runs/3185020300/jobs/5194097834#step:4:2)022-0[9](https://github.com/bottlerocket-os/bottlerocket-update-operator/actions/runs/3185020300/jobs/5194097834#step:4:10)-19)

warning: tool `rustfmt` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `cargo-fmt` is already installed, remove it from `/home/runner/.cargo/bin`, then run `rustup update` to have rustup manage this tool.

@jpculp
Copy link
Member Author

jpculp commented Oct 4, 2022

Maybe the runner has a different rust version than your local version?

I built locally on x86_64 and aarch64 using rust 1.64.0 and rust 1.61.0 (the version in the Bottlerocket SDK) prior to the rebase, but the weird linking error is still occurring. Since this isn't a high priority I'll drop it into draft and we can poke at it a bit more.

@jpculp jpculp marked this pull request as draft October 4, 2022 20:14
@jpculp
Copy link
Member Author

jpculp commented Oct 4, 2022

Dropped integ commit (for now).

@jpmcb
Copy link
Contributor

jpmcb commented Oct 4, 2022

Is this the linking error you saw? https://github.com/bottlerocket-os/bottlerocket-update-operator/actions/runs/3184235579/jobs/5192405098#step:5:343

Those look to have started a few hours ago 👀

@jpculp
Copy link
Member Author

jpculp commented Oct 4, 2022

Is this the linking error you saw? https://github.com/bottlerocket-os/bottlerocket-update-operator/actions/runs/3184235579/jobs/5192405098#step:5:343

Those look to have started a few hours ago 👀

The very same. We merged a couple dependabot updates this morning, but each of those were rebased and retested prior to merge.

Checking to see if bumping the builder image helps.

@jpculp
Copy link
Member Author

jpculp commented Oct 4, 2022

Temporarily taking caching out of the picture to make sure we aren't running out of disk space.

@jpculp
Copy link
Member Author

jpculp commented Oct 4, 2022

Removed testing commit and rebased now that we've cleared the cache.

@jpculp jpculp marked this pull request as ready for review October 4, 2022 22:27
Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed the controller / resources and all looks well! Thanks Patrick! 👏🏼

@jpculp jpculp merged commit d1c3ff4 into bottlerocket-os:develop Oct 5, 2022
@jpculp jpculp deleted the fix-clippy-warnings branch October 5, 2022 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants