Enables automatic prometheus scrapping for controller's service #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssue number:
Closes #159
Description of changes:
This commit adds the
to the controller service (so that prometheus may automatically start scraping metrics when deployed).
This also adds a missing namespace delimiter for the
prometheus-config
ConfigMap. Otherwise, I would get an error that the configmap could not be foundFrom the kubernetes docs:
Ref: https://kubernetes.io/docs/concepts/configuration/configmap/#configmaps-and-pods
Testing done:
Deployed cert-manager, the modified
bottlerocket-update-operator.yaml
, and the modifiedyamlgen/telemetry/prometheus-resources.yaml
to a bottlerocket based cluster.I see that automatically Prometheus starts scraping the metrics:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.