Refactors apiserver errors to be module specific
#279
Conversation
apiserver/src/api/error.rs
Outdated
| #[snafu(display("Unable to create client: '{}'", source))] | ||
| ClientCreate { source: kube::Error }, | ||
|
|
||
| pub enum ApiError { |
There was a problem hiding this comment.
Do you have preferences and any thoughts that make you keep this error.rs? I think might be better to delete this file and move the ApiError module to mod.rs? I'm not 100% confident that my way is better than yours. Love to hear your thoughts! thanks
There was a problem hiding this comment.
This made sense to live in it's own file since it denotes errors for the entire API module. I believe putting it in mod.rs would essentially accomplish the same thing; make these errors accessible to entire module (but not necessarily the crate). Still new to the rust paradigms, so up to what y'all think!
apiserver/src/api/error.rs
Outdated
| #[snafu(display("Unable to create client: '{}'", source))] | ||
| ClientCreate { source: kube::Error }, | ||
|
|
||
| pub enum ApiError { |
There was a problem hiding this comment.
Throughout our codebase (including other projects) we tend to use Error for all error enums instead of giving them bespoke names.
There was a problem hiding this comment.
Sounds good! I was following some of the other examples found in brupop:
Maybe these are due for a small refactor?
Signed-off-by: John McBride <jpmmcb@amazon.com>
jpmcb
force-pushed
the
apiserver-error-refactor
branch
from
91804d5
to
ea44780
Compare
|
Force pushed:
|
Issue number:
Related: #121
Description of changes:
Refactors the
apiservererror handling to be less generic and more module spcific.Testing done:
Coming soon
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.