Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove cache from brupop action #286

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Conversation

gthao313
Copy link
Member

@gthao313 gthao313 commented Oct 11, 2022

Description of changes:
caching on brupop action causes space issue, and me and @jpculp don't thinks caching help brupop a lot. So it's better to remove it.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

Copy link
Contributor

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏🏼 👏🏼 👏🏼

Copy link
Member

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit. I might make the commit message something a bit more descriptive like:
Remove caching from build workflow

@gthao313 gthao313 merged commit 75eb35d into bottlerocket-os:develop Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants