Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action to check for changes to yamlgen/deploy/... #314

Closed
jpmcb opened this issue Oct 25, 2022 · 1 comment · Fixed by #321
Closed

GitHub action to check for changes to yamlgen/deploy/... #314

jpmcb opened this issue Oct 25, 2022 · 1 comment · Fixed by #321
Assignees
@jpmcb

Comments

@jpmcb
Copy link
Contributor

jpmcb commented Oct 25, 2022

Issue or Feature Request:

There's been a few dependency upgrades that have changed the deployment yaml from under us. We should implement a GitHub action (probably just after the build step) to ensure the repo is "clean" so we aren't accidentally changing anything in the generated yamls.
@jpmcb jpmcb self-assigned this Oct 25, 2022
@webern
Copy link
Contributor

webern commented Oct 25, 2022

This is what we do over here https://github.com/bottlerocket-os/bottlerocket-test-system/blob/2a999cf11e300986983702d3174b5cfdf0c3c3e7/.github/workflows/build.yaml#L25

@jpmcb jpmcb mentioned this issue Oct 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpmcb jpmcb

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@webern @jpmcb