Enable port configurability #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcginnis
reviewed
Oct 25, 2022
gthao313
reviewed
Oct 25, 2022
gthao313
reviewed
Oct 26, 2022
|
Test looks good on my side. |
- Api-server: Port can be configured from default 8443 - Agent / webhook: Port can be configured from default 443 Signed-off-by: John McBride <jpmmcb@amazon.com>
|
Force pushed to address above nits/comments! ✍🏼 |
gthao313
approved these changes
Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes: #305
Description of changes:
Enables ports used by the API server and the agent to be configurable. Removes constant values and instead, interpolates from the container environment.
Testing done:
Ran through integration testing 👍🏼
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.