Expose failure output for apiclient #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jpmcb Since you create the issue, Can you take a look at this to verify if this change meet your expectation? Thanks! : ) |
cbgbt
reviewed
Nov 17, 2022
agent/src/apiclient.rs
Outdated
| statuscode: error_statuscode, | ||
| args: args, |
There was a problem hiding this comment.
Might be good to leave the status code there, which would make it easier to write code to handle the error elsewhere.
There was a problem hiding this comment.
+1 Agree with Sean. I think it'd make sense to have all 3:
- the command /args that were invoked
- the error status code
- the error contents
The agent calls to the bottlerocket API and it could fail for any number of reasons. Currently we only return the status code, so we improve update API invoke functionality to return entire error output for easier debugging.
jpmcb
approved these changes
Nov 18, 2022
webern
approved these changes
Nov 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent calls to the bottlerocket API and it could fail for any number of reasons. Currently we only return the status code, so we improve update API invoke functionality to return entire error output for easier debugging.
Issue number:
Closes: #335
Description of changes:
Testing done:
✅ Integration test
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.