Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

integration-test: enforce IMDSv2 calls when launching instances #405

Merged
merged 1 commit into from
Jan 30, 2023
Merged

integration-test: enforce IMDSv2 calls when launching instances #405

merged 1 commit into from
Jan 30, 2023

Conversation

gthao313
Copy link
Member

Issue number:
closes: #395

Description of changes:

Author: Tianhao Geng <tianhg@amazon.com>
Date:   Mon Jan 30 01:00:18 2023 +0000

    integration-test:  enforce IMDSv2 calls when launching **instances**

Testing done:
integration-test and confirm those instances had been enforced IMDSv2 calls.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

stmcginnis
stmcginnis approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good idea to me. Looks good!

jpmcb
jpmcb approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@jpmcb jpmcb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏🏼 ran the integration tests and see the instances created have HttpTokens required:

"HttpTokens": "required",

@jpmcb jpmcb merged commit 2784914 into bottlerocket-os:develop Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

@jpmcb jpmcb jpmcb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integration tests launch instances without enforcing IMDSv2 calls
3 participants
@gthao313 @stmcginnis @jpmcb