Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Deployment permission on the api server #466

Closed
jooh-lee opened this issue Jun 14, 2023 · 2 comments · Fixed by #507
Closed

Question: Deployment permission on the api server #466

jooh-lee opened this issue Jun 14, 2023 · 2 comments · Fixed by #507
Assignees

Comments

@jooh-lee
Copy link

jooh-lee commented Jun 14, 2023

Image I'm using:
v1.1.0

Issue or Feature Request:
I was just wondering why the api-server needs such broad rbac permissions in deployments. The ones im specifically wondering are these permissions:
"create",
"delete",
"deletecollection",
"patch",
"update"

these are giving some pretty broad range of permissions to the api-server, so if these aren't actually needed I would love to remove them or at the very least the create and delete permissions. I took a brief look through the code and the deep dive and nothing jumps out at me as to why it would need those.

Thank you for the help!

@cbgbt
Copy link
Contributor

cbgbt commented Jun 19, 2023

Thanks for raising this issue.

I agree that these seem more broad than necessary. I would like to think that "me in the past" would have appropriately constrained this role, but it's possible I mistakenly added these. I'll re-evaluate why these are in the policy and either:

  • Add some commentary if there is a valid reason.
  • Remove them if there is not.

@jooh-lee
Copy link
Author

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants