Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] Add setting for ReservedPorts/ReservedPortsUDP #1116

Open
samuelkarp opened this issue Sep 11, 2020 · 4 comments
Open

[ECS] Add setting for ReservedPorts/ReservedPortsUDP #1116

samuelkarp opened this issue Sep 11, 2020 · 4 comments
Labels
area/ecs ECS status/needs-info Further information is requested type/enhancement New feature or request
Milestone

Comments

@samuelkarp
Copy link
Contributor

Originally requested by @chathsuom in #815 (comment).

The ReservedPorts and ReservedPortsUDP fields cause the ECS agent to restrict tasks that use those ports from being placed on a given container instance.

@samuelkarp samuelkarp mentioned this issue Sep 11, 2020
@chathsuom
Copy link

chathsuom commented Sep 11, 2020

Thanks @samuelkarp
Use case behind this is, we use a custom SSH container which has some additional functionality (MFA etc.) which I cannot do with the admin controller. (Not so sure I am correct here though)
Next step, I will try if I can customise the admin controller to include our requirements.

@samuelkarp
Copy link
Contributor Author

If you want to replace the admin container and use yours instead, you can override the image used for the admin container through the settings.host-containers.admin.source setting. If you want to customize and extend the default admin container image, you can find the source for it here.

@samuelkarp
Copy link
Contributor Author

You can use any image you want, but our default one has some useful things you might want to include in your image. You mentioned that you've got your own SSH config, but for reference we use this script as the default command to start the container (which grabs the right public key and runs sshd) and this SSH config. We also include a statically-linked bash and a script called sheltie that effectively gives you a shell "on the host".

@samuelkarp samuelkarp added area/ecs ECS type/enhancement New feature or request labels Sep 29, 2020
@gregdek gregdek added this to the backlog milestone Apr 1, 2021
@stmcginnis stmcginnis added status/needs-triage Pending triage or re-evaluation and removed priority/p2 labels Dec 1, 2022
@stmcginnis stmcginnis added status/needs-info Further information is requested and removed status/needs-triage Pending triage or re-evaluation labels Feb 16, 2023
@stmcginnis
Copy link
Contributor

Anyone know if this is still needed? This issue has been open for some time now, and I don't think I've seen other requests for this. Just trying to clean up our backlog of issues, and if this isn't something that has been a big enough concern to address in the last 2+ years I'm wondering if it makes sense to just close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ecs ECS status/needs-info Further information is requested type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants