Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variant documentation: Document the ordering of user data sources #1456

Closed
zmrow opened this issue Apr 5, 2021 · 1 comment
Closed

Variant documentation: Document the ordering of user data sources #1456

zmrow opened this issue Apr 5, 2021 · 1 comment
Assignees
@zmrow
Labels
area/core Issues core to the OS (variant independent) type/documentation Documentation update/creation
Milestone
1.7.0

Comments

@zmrow
Copy link
Contributor

zmrow commented Apr 5, 2021

In #1393 , we added an additional source of user data for VMWare variants (guestinfo). In that PR, we opted to look at both sources of user data (CD-ROM and guestinfo), overriding settings found via CD-ROM with settings found in guestinfo.

If multiple sources are probed for user data, and their order determines which settings will be final, we need to document it. I propose we document this in the variants README.
@jhaynes jhaynes added area/core Issues core to the OS (variant independent) status/needs-triage Pending triage or re-evaluation type/bug Something isn't working labels Apr 8, 2021
@jhaynes jhaynes added this to the techdebt milestone Apr 9, 2021
@jhaynes jhaynes added type/documentation Documentation update/creation and removed type/bug Something isn't working labels Apr 9, 2021
@jhaynes jhaynes added priority/p1 and removed status/needs-triage Pending triage or re-evaluation labels May 3, 2021
@jhaynes jhaynes modified the milestones: techdebt, next+1 Aug 4, 2021
@kdaula kdaula modified the milestones: next+1, 1.7.0 Feb 4, 2022
@zmrow
Copy link
Contributor Author

zmrow commented Feb 8, 2022

This information was added the the variants README in #1903.

@zmrow zmrow closed this as completed Feb 8, 2022
@kdaula kdaula added this to v1.7.0 Feb 16, 2022
@kdaula kdaula moved this to Done in v1.7.0 Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zmrow zmrow

Labels
area/core Issues core to the OS (variant independent) type/documentation Documentation update/creation
Projects
No open projects
v1.7.0
Status: Done
Milestone
1.7.0
Development

No branches or pull requests
3 participants
@jhaynes @zmrow @kdaula