Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libseccomp to 2.53+ #1815

Closed
tjkirch opened this issue Nov 10, 2021 · 2 comments · Fixed by #1983
Closed

Update libseccomp to 2.53+ #1815

tjkirch opened this issue Nov 10, 2021 · 2 comments · Fixed by #1983
Assignees
Milestone

Comments

@tjkirch
Copy link
Contributor

tjkirch commented Nov 10, 2021

There's a conflict with systemd we'll have to figure out; this is what happens when trying to build systemd 247.10 after updating to libseccomp 2.53:

  #18 13.63 In file included from /x86_64-bottlerocket-linux-gnu/sys-root/usr/include/seccomp.h:821,                                                                        
  #18 13.63                  from ../src/shared/seccomp-util.c:6:                                                                                                           
  #18 13.63 ../src/shared/seccomp-util.c: In function 'seccomp_restrict_sxid':                                                                                              
  #18 13.63 ../src/shared/seccomp-util.c:2077:25: error: '__NR_openat2' undeclared (first use in this function); did you mean '__openat_2'?                                 
  #18 13.63  2077 |                         SCMP_SYS(openat2),                                                                                                              
  #18 13.63       |                         ^~~~~~~~
@cbgbt
Copy link
Contributor

cbgbt commented Feb 1, 2022

It looks like we'll want to include a version of systemd (or systemd + patches) which includes the fix from the issue linked above by @jlsalvador. Thanks for cross referencing!

Unfortunately our current version of systemd doesn't apply those patches cleanly. We'll probably want to table this until we have resolved #1671

@kdaula kdaula added this to the 1.7.0 milestone Feb 18, 2022
@kdaula kdaula added this to v1.7.0 Feb 18, 2022
@cbgbt cbgbt self-assigned this Feb 18, 2022
@bcressey bcressey self-assigned this Mar 4, 2022
@bcressey
Copy link
Contributor

bcressey commented Mar 4, 2022

Going to pull this into the work for #1983.

@bcressey bcressey mentioned this issue Mar 15, 2022
6 tasks
@bcressey bcressey moved this to Done in v1.7.0 Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants