Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest nightly, cargo dep update and remove workflow hacks #325

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

jmt-lab
Copy link
Contributor

@jmt-lab jmt-lab commented Jul 12, 2024

Description of changes:

  • updates nightly to 2024-07-11 so new used features in serde exist
  • updates cargo dependencies to ensure time is updated to a suported version for the nightly
  • removes previous workarounds in workflows

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@jmt-lab jmt-lab self-assigned this Jul 12, 2024
@jmt-lab jmt-lab force-pushed the fix-workflows branch 3 times, most recently from df3e654 to 64bd3c9 Compare July 15, 2024 21:17
Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly LGTM, though I think we will be happier if we maintain a versioned dependency on cargo-make, even if the version changes.

.github/workflows/rust.yml Show resolved Hide resolved
@jmt-lab jmt-lab merged commit e9c3d18 into bottlerocket-os:develop Jul 17, 2024
1 check passed
@jmt-lab jmt-lab deleted the fix-workflows branch July 17, 2024 17:34
@jmt-lab jmt-lab mentioned this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants