-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image handling bugs in twoliter update
#326
Conversation
8ed56a2
to
7cad644
Compare
^ A few force pushes to test the github actions changes. Maybe the tests will pass? 😬 |
354dac4
to
8ab4094
Compare
^ I realized that reference counting was no longer required now that the |
Apologies for the churn, but I noticed an error in a comment, and also decided that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
curl -sL "https://github.com/google/go-containerregistry/releases/download/${VERSION}/go-containerregistry_Linux_${ARCH}.tar.gz" > go-containerregistry.tar.gz | ||
tar -zxvf go-containerregistry.tar.gz -C "${{ inputs.install-dir }}" crane | ||
|
||
echo "${{ inputs.install-dir }}" >> "${GITHUB_PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
pub struct ImageTool { | ||
image_tool_impl: Box<dyn ImageToolImpl>, | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this so so much more :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
|
||
VERSION=${{ inputs.crane-version }} | ||
if [[ "${VERSION}" == "latest" ]]; then | ||
VERSION=$(curl -s "https://api.github.com/repos/google/go-containerregistry/releases/latest" | jq -r '.tag_name') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The --format string erroneously surrounded the output of `docker image inspect` in quotes, causing the JSON parser to read the output as a string instead of an object.
Prior to canonicalizing image manifests, crane and docker would result in slightly different image digests due to non-semantic formatting differences.
^ force-push to use |
^ force-push to rebase on |
^ Bah, I misunderstood where the |
Issue number:
n/a
Description of changes:
Testing done:
twoliter update
thebottlerocket
repo to core-kit 2.1.0.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.