Fix image handling bugs in twoliter update
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbgbt
force-pushed
the
img-inspect
branch
3 times, most recently
from
8ed56a2
to
7cad644
Compare
|
^ A few force pushes to test the github actions changes. Maybe the tests will pass? 😬 |
cbgbt
force-pushed
the
img-inspect
branch
2 times, most recently
from
354dac4
to
8ab4094
Compare
|
^ I realized that reference counting was no longer required now that the |
|
Apologies for the churn, but I noticed an error in a comment, and also decided that the |
jmt-lab
approved these changes
Jul 17, 2024
| curl -sL "https://github.com/google/go-containerregistry/releases/download/${VERSION}/go-containerregistry_Linux_${ARCH}.tar.gz" > go-containerregistry.tar.gz | ||
| tar -zxvf go-containerregistry.tar.gz -C "${{ inputs.install-dir }}" crane | ||
|
|
||
| echo "${{ inputs.install-dir }}" >> "${GITHUB_PATH}" |
| pub struct ImageTool { | ||
| image_tool_impl: Box<dyn ImageToolImpl>, | ||
| } | ||
|
|
There was a problem hiding this comment.
I like this so so much more :D
sam-berning
approved these changes
Jul 17, 2024
bcressey
approved these changes
Jul 17, 2024
|
|
||
| VERSION=${{ inputs.crane-version }} | ||
| if [[ "${VERSION}" == "latest" ]]; then | ||
| VERSION=$(curl -s "https://api.github.com/repos/google/go-containerregistry/releases/latest" | jq -r '.tag_name') |
The --format string erroneously surrounded the output of `docker image inspect` in quotes, causing the JSON parser to read the output as a string instead of an object.
Prior to canonicalizing image manifests, crane and docker would result in slightly different image digests due to non-semantic formatting differences.
|
^ force-push to use |
|
^ force-push to rebase on |
|
^ Bah, I misunderstood where the |
bcressey
approved these changes
Jul 17, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
n/a
Description of changes:
Testing done:
twoliter updatethebottlerocketrepo to core-kit 2.1.0.Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.