Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Use-Case Diagram According to the Feedback #124

Closed
11 tasks done
xltvy opened this issue Apr 11, 2022 · 3 comments
Closed
11 tasks done

Editing Use-Case Diagram According to the Feedback #124

xltvy opened this issue Apr 11, 2022 · 3 comments
Assignees
Labels
diagrams Related to use-case/class/sequence diagrams enhancement New feature or request priority-high High level priority issue Status: Completed Issue is solved type-system design System design related

Comments

@xltvy
Copy link
Contributor

xltvy commented Apr 11, 2022

Issue Description

In the third customer meeting at 06.04.2022, we have gone over our UML diagrams. For the use-case diagram there were some minor issues. I categorized those in two categories: general and specific issues.

General Issues:

  • As nodes of the diagram we should use actions, not class names. - @xltvy
  • Instead of using <includes>opt. we should use <extends> for the optional cases. @bahricanyesil
  • When using link between the nodes the direction of arrow is from child to parent. - @xltvy

Specific Issues:

  • For browsing we should use includes, not extends. - @xltvy
  • Enroll-review course should be extends, not includes. @bahricanyesil
  • We should remove check completion percentage. @bahricanyesil
  • When creating a course setting privacy options should be includes. - @xltvy
  • For admins, giving a reason for their actions should be includes. - @xltvy

These issues are subject to change. There may be more issues to be added or removed from those above lists.

Step Details

Steps that will be performed:

  • Specific issues will be resolved.
  • General issues will be resolved.
  • Use-case diagram will be finalized.

Final Actions

After each issue related to the use-case diagrams is resolved, use-case diagram will be finalized and added to the according page in our wiki.

Deadline of the Issue

12.04.2022 - Tuesday - 22.00

Reviewer

Onur Kömürcü

Deadline for the Review

12.04.2022 - Tuesday - 23.59

@xltvy xltvy added enhancement New feature or request priority-high High level priority issue status-new New issue in initial state diagrams Related to use-case/class/sequence diagrams type-system design System design related labels Apr 11, 2022
@xltvy xltvy self-assigned this Apr 11, 2022
@xltvy
Copy link
Contributor Author

xltvy commented Apr 11, 2022

Info

I have edited course creation part of the use-case diagram according to the feedback given and also corrected some wrong directed extends arrows throughout the whole diagram

@xltvy xltvy added status-inprogress Issue is currently worked and removed status-new New issue in initial state labels Apr 11, 2022
@bahricanyesil
Copy link
Contributor

Info

  • I changed the relation between enrolling a course and reviewing it to "extends" instead of "includes" since it is optional.
  • I removed the "Check completion percentage" node from the reviewing a course part as we discussed in the PS.
  • I checked the "opt." relations over the whole graph and changed the encountered ones with "" keyword.

@xltvy xltvy added Status: Completed Issue is solved and removed status-inprogress Issue is currently worked labels Apr 13, 2022
@xltvy
Copy link
Contributor Author

xltvy commented Apr 13, 2022

Info

I have revised the remaining parts of the use-case diagram and resolved remaining specific and general issues. Now, use-case diagram is finalized and is ready to be added to the relevant wiki page.

@xltvy xltvy closed this as completed Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagrams Related to use-case/class/sequence diagrams enhancement New feature or request priority-high High level priority issue Status: Completed Issue is solved type-system design System design related
Projects
None yet
Development

No branches or pull requests

2 participants