Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Providing mockups for Creating Community Events #56

Closed
hasancan-code opened this issue Mar 22, 2022 · 3 comments
Closed

Providing mockups for Creating Community Events #56

hasancan-code opened this issue Mar 22, 2022 · 3 comments
Assignees
Labels
priority-medium Medium level priority issue Status: Completed Issue is solved

Comments

@hasancan-code
Copy link
Contributor

hasancan-code commented Mar 22, 2022

Issue Description

As we have discussed and determined in meeting3, I took the responsibility of providing mockups for the scenario of creating community events. Pre-Conditions for Community Events and the scenario is accessible in issue #50

After the initial phase of providing mockups is finished,

Step Details

No response

Final Actions

I completed the mockups for the scenario. This issue will be closed and mockups will be added to the wiki page after reviewing the process.
You can check figma link.

Deadline of the Issue

22.03.2022 Tuesday 23:59

Reviewer

Muhammed Enes Sürmeli

@hasancan-code hasancan-code added priority-medium Medium level priority issue status-new New issue in initial state labels Mar 22, 2022
@ezgy
Copy link
Contributor

ezgy commented Mar 22, 2022

I've reviewed your design on figma and have one simple suggestion: currently, the way fields are designed contains duration as minutes and date as day/month/year, which makes it so the start time of the event is unknown. Perhaps we can change the "duration" to a format similar to google calendar (17.00-18.30) or add an additional field start: to enter starting time?

@surmelienes1
Copy link
Contributor

surmelienes1 commented Mar 22, 2022

As Ezgi mentioned above, an addition can be made for the start time of a created meeting so that we can eliminate the uncertainty, and an e letter is missing between the letters c and m when writing "announcements" on the last page, but it is not a big problem.

Other than that, from my point of view, I don't see any changes which needs to be made. It looks very good and complete, great job! Thank you Hasan Can for your valuable contributions.

If you don't have further questions, suggestions, or ideas, you can close this issue.

@hasancan-code
Copy link
Contributor Author

Thanks for the reviews Ezgi and Enes. I made the necessary changes. You can check from figma link.

@hasancan-code hasancan-code added Status: Completed Issue is solved and removed status-new New issue in initial state labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority-medium Medium level priority issue Status: Completed Issue is solved
Projects
None yet
Development

No branches or pull requests

3 participants