Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Implement geolocation selection screen #887

Closed
3 tasks done
egemenatikk opened this issue Dec 26, 2022 · 2 comments
Closed
3 tasks done

Mobile: Implement geolocation selection screen #887

egemenatikk opened this issue Dec 26, 2022 · 2 comments
Assignees
Labels
feature New feature mobile Mobile related items priority-high High level priority issue Status: Completed Issue is solved

Comments

@egemenatikk
Copy link
Contributor

egemenatikk commented Dec 26, 2022

Issue Description

While creating an event, users should be able to select the geolocation of event from a map. Create event screen is implemented in #842 and after implementation of geolocation selection screen, create event functionality for mobile will be fully implemented.

Step Details

Steps that will be performed:

  • Add geolocation selection screen
  • Set geolocation when another geolocation is selected by user
  • Test create event functionality

Final Actions

After all steps mentioned above are completed, a corresponding pull request will be opened. Merging that pull request will close this issue.

Deadline of the Issue

26.12.2022 - Monday -23:59

@egemenatikk egemenatikk added priority-high High level priority issue status-new New issue in initial state feature New feature mobile Mobile related items labels Dec 26, 2022
@egemenatikk egemenatikk self-assigned this Dec 26, 2022
@egemenatikk egemenatikk added status-inprogress Issue is currently worked and removed status-new New issue in initial state labels Dec 26, 2022
@egemenatikk
Copy link
Contributor Author

Instead of creating a separate screen for geolocation selection, I added a component for it to create event screen, directly. Here is a screenshot of that component:

image

It still has some problems in terms of state management, it does not re-render when clicked but it works prooperly after a hot refresh. @bahricanyesil will try to solve this problem.

@egemenatikk egemenatikk added status-needreview A review to the issue is needed and removed status-inprogress Issue is currently worked labels Dec 26, 2022
@egemenatikk
Copy link
Contributor Author

Corresponding pull request, #897, is merged. So, this issue fixed and can be closed now.

@egemenatikk egemenatikk added Status: Completed Issue is solved and removed status-needreview A review to the issue is needed labels Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature mobile Mobile related items priority-high High level priority issue Status: Completed Issue is solved
Projects
None yet
Development

No branches or pull requests

1 participant