Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting Backend code conventions #262

Closed
2 tasks done
canberkboun9 opened this issue Oct 30, 2022 · 7 comments
Closed
2 tasks done

Documenting Backend code conventions #262

canberkboun9 opened this issue Oct 30, 2022 · 7 comments
Assignees
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Backend Backend based work - for backend team Type: Documentation Improvements or additions to documentation

Comments

@canberkboun9
Copy link
Contributor

canberkboun9 commented Oct 30, 2022

Description:

Coding conventions help the developing team to understand each other's code and communicate ideas. The benefits of these rules can be seen more effectively in a large team. We have 4 people in the backend team. It is not such a big team, but some code convention might be reasonable to have.

Todo's:

  • Create a page for the backend code conventions
  • Create the conventions, edit the page.

Reviewer: @oguzhandemirelx

Task Deadline: 30.10.2022 23:00
Review Deadline: 31.10.2022 23:00

@canberkboun9 canberkboun9 added Type: Documentation Improvements or additions to documentation Prio: Medium Importance of Issue: Medium Status: In Progress Issue is worked on, currently Team: Backend Backend based work - for backend team labels Oct 30, 2022
@canberkboun9 canberkboun9 self-assigned this Oct 30, 2022
@canberkboun9
Copy link
Contributor Author

canberkboun9 commented Oct 30, 2022

  • Created the page, and conventions in it.
  • Added it to the Sidebar.

@canberkboun9 canberkboun9 added Status: Need Review Issue work is done, waiting to be reviewed and removed Status: In Progress Issue is worked on, currently labels Oct 30, 2022
@oguzhandemirelx
Copy link
Contributor

Excellent job, Canberk. I think we can add [Error 500 - Internal Server Error] to our error handling part because we will probably encounter them too. Also, we can add comment conventions for the backend team to our page.

@mehmetemreakbulut
Copy link
Contributor

Great! Also, we can add code style and conventions from official Django documentation as a relevant link.

@canberkboun9
Copy link
Contributor Author

canberkboun9 commented Oct 31, 2022

Excellent job, Canberk. I think we can add [Error 500 - Internal Server Error] to our error handling part because we will probably encounter them too. Also, we can add comment conventions for the backend team to our page.

Thanks, I will add the error code. Comments should not be considered as documentation examples, I think. Too much of them and some unnecessary ones make the code cluttered. And the convention should be to write them in the code to translate complex parts. We can add some details about commenting, like:

  • We should write comments in a new line under the code line we prefer.
  • Comments should end with a ".".

Also, we can use some documentation tools generating documentation from comments over functions etc. I forgot the name now.

Great! Also, we can add code style and conventions from official Django documentation as a relevant link.

Nice suggestion, but, can you add it like in your mind? I don't know which parts to add.

@mehmetemreakbulut
Copy link
Contributor

Excellent job, Canberk. I think we can add [Error 500 - Internal Server Error] to our error handling part because we will probably encounter them too. Also, we can add comment conventions for the backend team to our page.

Thanks, I will add the error code. Comments should not be considered as documentation examples, I think. Too much of them and some unnecessary ones make the code cluttered. And the convention should be to write them in the code to translate complex parts. Also, we can use some documentation tools generating documentation from comments over functions etc. I forgot now.

Great! Also, we can add code style and conventions from official Django documentation as a relevant link.

Nice suggestion, but, can you add it like in your mind? I don't know which parts to add.

Yes, I added the relevant links that we use.

@canberkboun9
Copy link
Contributor Author

I added the comment conventions, I think we can close the issue.

@oguzhandemirelx
Copy link
Contributor

Yes, everything looks good. Thanks for your effort.

@mehmetemreakbulut mehmetemreakbulut added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Team: Backend Backend based work - for backend team Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants