Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Functional/User Requirements section of the project #33

Closed
kardelendemiral opened this issue Mar 16, 2022 · 7 comments
Closed
Assignees
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Type: Documentation Improvements or additions to documentation

Comments

@kardelendemiral
Copy link
Contributor

Requirements will be added to Functional Requirements/User Requirements.

Reviewers: @canberkboun9 , @enginoguzhansenol

Task Deadline: 17.03.2022 - 18:00 GMT+3
Review Deadline: 17.03.2022 - 20:00 GMT+3

@kardelendemiral kardelendemiral added Type: Documentation Improvements or additions to documentation Prio: Medium Importance of Issue: Medium Status: In Progress Issue is worked on, currently labels Mar 16, 2022
@kardelendemiral
Copy link
Contributor Author

kardelendemiral commented Mar 16, 2022

Additional requirements can be suggested by the team members.

@kardelendemiral
Copy link
Contributor Author

kardelendemiral commented Mar 16, 2022

Since it is not decided yet whether our application will have a 'follow' functionality for the users, I did not add the following requirements. If we decide that this functionality will be provided, they can be added.

1.1.1.3 Profile Pages:

  • Users shall be able to follow other users going to their profile pages.
  • Users shall be able to see their follower list in their profile pages.
  • Users shall be able to see their followed users list in their profile pages.

@kardelendemiral kardelendemiral added Status: Need Review Issue work is done, waiting to be reviewed and removed Status: In Progress Issue is worked on, currently labels Mar 16, 2022
@canberkboun9
Copy link
Contributor

canberkboun9 commented Mar 17, 2022

  • Users shall be able to follow other users (by) going to their profile pages. -> Maybe this addition might clear the ambiguity.

Requirements:

  • Under 1.1.1.1: Users shall verify their identity (by providing authentication via their doctor's ID, diploma, or some other legal verification method.)
  • We might want to talk about "nickname" feature.
  • Users shall (be able to) register their previous medical conditions to the system.
  • Under 1.1.1.2: Users shall be able to sign-in if they forget their password if they can verify their identity and they shall choose a new password. -> We might want to change this such that it's main idea would be "forgot password" mechanism.
  • Under 1.1.1.3: Users shall be able to sign-out. -> I am not sure whether this requirement should be in this section.
  • Enumeration of the requirements to match with other sections would be nice.
  • Nice work! Eline sağlık.

@bbenginbestas
Copy link
Contributor

Great work Kardelen! I think 'follow' functionality sounds great and we can discuss it further.
Also great review Canberk, I went ahead and changed some parts according to your review.

  • Under 1.1.1.1: Users shall (be able to) register.
  • Under 1.1.1.2: Changed the text to forget password mechanism.
  • Enumerated so it would match other sections.
    Also:
  • Changed the position of some entries so that it would look better and would be more organized.
  • Changed some of the words.

@kardelendemiral
Copy link
Contributor Author

kardelendemiral commented Mar 18, 2022

I made modifications according to the Meeting 3.1 feedback:

  • Added definitions of User, Registered User, Doctor, Member, Guest User, Personal Information, Public Personal Information, Protected Personal Information and Private Personal Information to the Glossary.
  • Modified the requirements according the user types specified in the glossary.
  • Modified the requirements according the personal information types specified in the glossary.
  • Removed the User Types section and added the requirements under this section to other appropriate sections.
  • Changed 6 characters for the password requirement to 8 characters.
  • Divided the profile picture requirements into two which are for doctors: profile picture, for members: avatar.
  • Changed all "previous medical conditions" terms to "medical history".

@canberkboun9
Copy link
Contributor

canberkboun9 commented Mar 21, 2022

Review:

Great work! Consistency is achieved for user requirements. I think we may call this part done and close the issue. However, if needed in the future, it could be opened again and further modifications could be added as comments.

@kardelendemiral
Copy link
Contributor Author

Thank you for the review @canberkboun9. I am closing the issue for now.

@kardelendemiral kardelendemiral added Status: Accepted Issue is reviewed, accepted and removed Status: Need Review Issue work is done, waiting to be reviewed labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prio: Medium Importance of Issue: Medium Status: Accepted Issue is reviewed, accepted Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants