Is ignore in bower.json necessary? #1388
Comments
|
The same for There always will be some false positives, and I have no idea how to resolve them. For now I think it's better to show this message so developers notice the problem. |
|
I see. I agree it's a warning not an error so probably not a big deal. Seems like currently the best practice is just to define a |
|
grunt is aborting due it's finding warnings, but setting a main or empty ignore fields doesn't fix it, how it's supposed to work this issue? |
|
It shouldn't abort due to warnings :) Warnings are warnings, not errors. |
|
"Aborted due to warnings", says. Anyway we have fixed the problems and grunt could be able to run :-) |
avoid 'invalid-meta angular-bootstrap-affix is missing "ignore" entry in bower.json' when installing via bower. As suggested here: bower/bower#1388
…ng "ignore" entry in bower.json' when installing via bower. As suggested here: bower/bower#1388
…ng "ignore" entry in bower.json' when installing via bower. As suggested here: bower/bower#1388
* canary: (23 commits) docs(overview): fix typo in English conceptual overview chore(): Fix typo chore(tests): fix typo in midway setup fix(service): use hasOwnProperty of prototype #638 fix(service): add shim for indexOf and trim #638 fix(bower.json): Avoid 'invalid-meta angular-bootstrap-affix is missing "ignore" entry in bower.json' when installing via bower. As suggested here: bower/bower#1388 fix(docs): fix example in directive ngdoc-documentation (fixes #678) Update CONTRIBUTING.md fix(translateService): fixup/rewrite for b48f6bb (specs) fix(translateService): prevent multiple XHR calls fix(directive): improve the cloak-directive's performance fix(directive): change event for listening to `$translateChangeEnd` fix(service): load fallback languages also for instant and filter fix(storage): fixup 75504cb fix(storage): fix 'DOM Exception 18' at feature detection chore(): update to latest bower (invalid transient dependencies) fix(package.json): remove unnecessary relative paths from package.json fix(service): addition of preferred language to fallback language stack is now preventing duplication if already contained in the fallback stack feat(service): preferredLanguage can now be set during runtime fix(demo): fixes wrong method call in demo fix(docs): Fix typo ...
|
When is this going to be fixed? Currently bower complains and returns a non-zero exit status when using a url to a repository index.js which has no bower.json. Bower generates a This ruins deploy scripts that expect a non-zero (ie non failing) bower install. Why is this 'ignore' key even mandatory at all? Just seems like a bad idea to require the key to begin with. |
|
I agree with @ahacking here, this is not an error so there's no point in returning non-zero exit code when this happens. |
|
Well, warning is OK, but non-zero status is a bug if it actually happens. I need to confirm. |
|
Sorry, false alarm. I tested it and it doesn't actually happen, status code returned is 0, it's the appearance of warning that made our deploy system think it's a failure. |
Gets rid of this "invalid-meta" warning:  bower/bower#1388
|
But why even output a warning? I cannot understand why something that is optional generates a warning. It seems like very strange logic. |
|
+1. Don't see a point to generate such warning. I have nothing to ignore in my repo and adding an empty |
|
++ |
…en installing via bower As suggested here: bower/bower#1388
When installing
angular1.3.0-beta.14, I received below warning:However due to the use of a very stripped down repo specifically for bower, there's no point of ignoring anything:
https://github.com/angular/bower-angular
Is it necessary to warn bower user that the package's
bower.jsonis "invalid" if it's missingignorekey?The text was updated successfully, but these errors were encountered: