Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD Changes #24

Closed
matthewdevenny opened this issue Oct 21, 2021 · 0 comments · Fixed by #25
Closed

CRD Changes #24

matthewdevenny opened this issue Oct 21, 2021 · 0 comments · Fixed by #25
Assignees

Comments

@matthewdevenny
Copy link
Member

matthewdevenny commented Oct 21, 2021

Helm currently doesn't allow customization of Kind sorting. Update DockhandSecret and DockhandSecretsProfile to Secret and Profile

  • Change apiVersion from dockhand.boxboat.io to dhs.dockhand.dev
  • Change kind: DockhandSecret to Secret
  • Change kind: DockhandSecretsProfile to Profile
  • Change Label dockhand.boxboat.io/autoUpdate to dhs.dockhand.dev/autoUpdate
  • Change internal annotations from dockhand.boxboat.io to dhs.dockhand.dev

Deprecation version: v1alpha1 DockhandProfile

  • version: dockhand.boxboat.io/v1alpha1 -> version: dhs.dockhand.dev/v1alpha2
  • kind: DockhandProfile -> kind: Profile

Deprecation version: v1alpha1 DockhandSecret

  • version: dockhand.boxboat.io/v1alpha1 -> version: dhs.dockhand.dev/v1alpha2
  • kind: DockhandSecret -> kind: Secret
  • profile: <profile-name> -> profile.name: <profile-name> profile.namespace: <profile-namespace>
    • profile field is now an object that contains a name and namespace field.
    • v1alpha1 assumed DockhandProfiles existed in dockhand-secrets-operator namespace and did not support multi-tenant use case. v1alpha2 allows the operator to operate in a multi-tenant mode or a single tenant mode where Profiles can be referenced in any namespace where the dockhand-secrets-operator has read access.

The motivation for this change is ensure that the helm Kind sorter creates a secret.dhs.dockhand.dev before attempting to create Deployments, StatefulSets or DaemonSets. This will prevent an unnecessary rollover when using the autoUpdate label. Previous dockhand.boxboat.io/autoUpdate will also continue to be supported until the next major release.

See kind_sorter and open issue to allow custom sorting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant