-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gurk always creates a log file even if verbose
is turned off
#204
Comments
Accoding to xdg dirs logs should go into the state dir, however it is not available on MacOS/Windows. So, I am not entirely sure if it is a good idea to put logs in to the |
Thanks for the quick fix!
Good point! |
When running
gurk
it seems to always create agurk.log
file in the current directory even when running without verbose mode (I guess that happens here: https://github.com/boxdot/gurk-rs/blob/master/src/main.rs#L51). Could a check be added to only create this file if the verbose mode is enabled, or better yet put it in a proper location like~/.local/share/gurk
?The text was updated successfully, but these errors were encountered: