Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: use 'Compile' function to get regular expression of exclude path #273

Closed
foxdd opened this issue Jul 17, 2021 · 1 comment · Fixed by #272
Closed

Suggestion: use 'Compile' function to get regular expression of exclude path #273

foxdd opened this issue Jul 17, 2021 · 1 comment · Fixed by #272
Labels
bug Something isn't working

Comments

@foxdd
Copy link
Contributor

foxdd commented Jul 17, 2021

we've met a problem in the daily use of SCC tool, which is, when the input exclude path list contains an incorrect regular expression, the entire scan process will be interrupted and a panic is thown out. So i think Compile function may be more user-friendly, so the process will continue and only the incorrect exclude path will be ignored

@boyter
Copy link
Owner

boyter commented Jul 19, 2021

Yeah panic is pretty much the wrong approach.

Added one small comment on the PR to ensure we surface the error though so the user is always informed if this is the case.

@boyter boyter added the bug Something isn't working label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants