Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RISCV assembly - can't count comments #429

Closed
rcordeau opened this issue Feb 9, 2024 · 2 comments
Closed

RISCV assembly - can't count comments #429

rcordeau opened this issue Feb 9, 2024 · 2 comments

Comments

@rcordeau
Copy link

rcordeau commented Feb 9, 2024

Describe the bug
Trying to compare against sloccount, and scc's ability to accurately count riscv assembly is off. It doesn't factor out comments (it can't see them)

To Reproduce
scc as a command
./scc asm_f.S

/****************************************************************************\

  • This is a comment block

****************************************************************************/

#include "thread_def.h"

.global ASM_ReturnToUserThread

Expected behavior
I expected an accurate count. of 2, but I got 7

Linux Ubuntu 22.04

@boyter
Copy link
Owner

boyter commented Feb 11, 2024

Yeah, .s would be picked up as Assembly and according to the rules https://github.com/boyter/scc/blob/master/languages.json#L414 there is noting for multiline comments.

Ill add it in now. You can get this if you build from source but with the new Go release ill be crafting a new build soon.

@boyter boyter closed this as completed in 9b762cd Feb 11, 2024
@boyter
Copy link
Owner

boyter commented Feb 11, 2024

Build from source should resolve this. Otherwise give it a few days and ill push out a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants