Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] resize images for display #50

Closed
palitu opened this issue Feb 10, 2019 · 4 comments
Closed

[Suggestion] resize images for display #50

palitu opened this issue Feb 10, 2019 · 4 comments
Milestone

Comments

@palitu
Copy link

palitu commented Feb 10, 2019

Is it possible to resize an image for viewing in 'full screen'? I have some images which are in the order of 10Mb each.

  • huge images are not good for mobile bandwidth
  • longer load times

My suggestions is that the images a resized to a smaller resolution that is suitable for display on a screen. There are a number of dynamic methods of doing this, but the simplest implementation would be to have a configuration item which you set a static maximum size for the image. It could even be opt in/out. download would still be the original file.

This would require a little more work on part of the server, but should not be too onerous.

future improvements could be:

  • create mediums during index
  • dynamic sizes based on screen resolution

cheers

@bpatrik
Copy link
Owner

bpatrik commented Feb 11, 2019

Hi

I was considering to resize/encode original media files.
Especially for videos since browsers can only play a very few codes + in case of a large file, no way to watch a video over my home internet.

For photos I'll do something similar what I do with the thumbnails. (like you can add certain resolutions, like 720p, 1080p, 4k, infinite and the app chooses the most appropriate one)

So I'll add this. But again no promise for a deadline. But I might take it with a higher priority, since its a relatively simple feature.

Patrik

@palitu
Copy link
Author

palitu commented May 1, 2019

G'day Patrik,

just wondering if you have had a chance to look into this one?

No pressure if you havent, just curious.

cheers,

@bpatrik
Copy link
Owner

bpatrik commented May 1, 2019

Hi,

Sorry but I got super busy with finishing up my PHD.
I'm still working on finishing #56.
Hopefully I'll have more time during the summer or during fall.

Best,
Patrik

@bpatrik
Copy link
Owner

bpatrik commented Dec 15, 2019

Hi,

I have added this feature in one of the latest commits.
Should be part of soon-to-be-released v1.8.
There are several breaking changes both in docker and config. Read more here: https://github.com/bpatrik/pigallery2/blob/master/docker/README.md

Best,
Patrik

@bpatrik bpatrik closed this as completed Dec 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants