-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues with sites using Emoji Favicon Toolkit #49
Comments
Sorry for slowest turnaround ever. This should be fixed when I release Favioli 2.00. Will close this issue at that time. Fix is basically to actually check for existing favicon links instead of relying on browser to override favicon in preferred order: d3de7f1 The actual code for ^ will probably change before release, since I want to make sure I still add a favicon for sites with bad urls / 404s. But I will keep this usecase in mind when I edit. Note: this will effect autofill specifically (the feature that fills in missing favicon). If a user is specifically trying to override the favicon of a website using Emoji Favicon Toolkit, Favioli will side on the user preference. Video of fix: 49.-.fix.mov |
When v2.00 is released, will it support holographic emoji? I hear they will be the new cool thing in about a decade, so the timing should be about right. 😆 🤣 🤣 🤣 😸 I'm just teasin' ya... take your time... this extension is like a fine wine, except I can afford this extension. 🍷 🤣 |
🗿 Haha the difference is that now I've actually stopped procrastinating on it 😛. Almost feature even with 1.00 now... Only hard thing left is re-implementing the favicon selector ui, since I want to have the support for custom images right off the bat. |
Sounds real good. Take your time. Have fun with it. |
Favioli resets the favicon to the default ServiceWorker-cached /favicon.ico on sites that use Emoji Favicon Toolkit, such as https://eligrey.com.
I use EFT here: https://eligrey.com/blog/wp-content/themes/eligrey.com/js/favicon.js
Expected results: Favicon is set to one of: 👨🔬 👨💻 👨🚀 🤯 🤖 ⚡ 🌧️ 🚀 💻 🧠 👻 📜 ☄️ 🛸 🌌 🌠 🛰️ ✨ 🔥✈️ ☕️ 🍕 🐱💻 and changes to 💬 whenever any input elements get modified.
Observed results: Favicon is set to 🛠️ (default favicon) and never changes.
The text was updated successfully, but these errors were encountered: