fix(vm): ignore ssd disk flag with virtio interface #231
Conversation
There was a problem hiding this comment.
Hey @abdo-farag! Thanks for the PR!
I have couple of comments, could you take a look pls?
Makefile
Outdated
| @@ -2,7 +2,8 @@ GOFMT_FILES?=$$(find . -name '*.go' | grep -v vendor) | |||
| NAME=terraform-provider-proxmox | |||
| TARGETS=darwin linux windows | |||
| TERRAFORM_PLUGIN_EXTENSION= | |||
| VERSION=0.12.0 # x-release-please-version | |||
There was a problem hiding this comment.
Hi @bpg
This space makes some problems with me when building on Linux with zsh.
So when I run init with this space I get error.
terraform init
Error: Failed to query available provider packages
Could not retrieve the list of available versions for provider bpg/proxmox: provider registry.terraform.io/bpg/proxmox was not found in any of the search locations
It's wierd somehow. but anyway if it bother you I will remove it.
There was a problem hiding this comment.
Hmmm, that's interesting. My guess is when you run make it sets VERSION exactly to 0.12.0 # x-release-please-version 🤦🏻
Good find, I'll take a look.
| @@ -2488,7 +2488,9 @@ func resourceVirtualEnvironmentVMGetDiskDeviceObjects( | |||
| diskDevice.Size = &sizeString | |||
| diskDevice.SizeInt = &size | |||
| diskDevice.IOThread = &ioThread | |||
| diskDevice.SSD = &ssd | |||
| if strings.Contains(diskInterface, "scsi") { | |||
There was a problem hiding this comment.
From the PVE docs:
Note that SSD emulation is not supported on VirtIO Block drives.
so I think this should be reflected in the condition then, i.e. if !strings.HasPrefix(diskInterface, 'virtio') {...}.
Also linter doesn't like cobbling if statements with unrelated assignments, so you may want to move this if block down a little bit, after the line 2494
bpg
changed the title
ghost
mentioned this pull request
Community Note
Relates OR Closes #0000