fix(vm): Make mac_address computed, fix #339 #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fields `network_interface_names`, `ipv4_addresses` and `ipv6_addresses` are sometimes be marked `computed` again, using `CustomizeDiff`. Changes in `VMStarted` or `VMNetworkDevice` attributes invalidate those values. Marking fields `computed` again avoids stale values. `network_device` configuration block without `mac_address` results in MAC address set to its default value (an empty string). Terraform state expects `mac_address` to be an empty string, server provides the actual (random) MAC address of the network device. Terraform detects there are changes to be made, but because of `DiffSuppressFunc` on `mac_address` they are hidden from the user, but not from d.HasChange(mkResourceVirtualEnvironmentVMNetworkDevice) By making `mac_address` also `computed`, the server-generated MAC address is stored locally, avoiding spurious changes that trigger re-computation of `network_interface_names`, `ipv4_addresses` and `ipv6_addresses`.
bpg
approved these changes
Jun 1, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields
network_interface_names,ipv4_addressesandipv6_addressesare sometimes be markedcomputedagain, usingCustomizeDiff. Changes inVMStartedorVMNetworkDeviceattributes invalidate those values. Marking fieldscomputedagain avoids stale values.network_deviceconfiguration block withoutmac_addressresults in MAC address set to its default value (an empty string). Terraform state expectsmac_addressto be an empty string, server provides the actual (random) MAC address of the network device. Terraform detects there are changes to be made, but because ofDiffSuppressFunconmac_addressthey are hidden from the user, but not from d.HasChange(mkResourceVirtualEnvironmentVMNetworkDevice)By making
mac_addressalsocomputed, the server-generated MAC address is stored locally, avoiding spurious changes that trigger re-computation ofnetwork_interface_names,ipv4_addressesandipv6_addresses.Contributor's Note
Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.
/docsfor any user-facing features or additions./examplesfor any new or updated resources / data sources.make examplesto verify that the change works as expected.Community Note
Relates OR Closes #339