fix(vm): fixed startup / shutdown behaviour on HA clusters #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to how a Proxmox cluster reacts to a VM shutdown command when running in HA mode, the VM might still be running when the shutdown API calls returns. This commit adds a loop that actively waits for the VM's status to change to "stopped" (while also accounting for the shutdown timeout) after the call's return.
…cluster This commit forces the plugin to wait for a VM to actually run after requesting it to be started. This avoids problems with Proxmox's High Availability mode, where a start request may not be immediately honoured by the cluster.
|
@all-contributors please add @tseeker for bug, tests |
|
I've put up a pull request to add @tseeker! 🎉 |
bpg
reviewed
Aug 20, 2023
proxmoxtf/resource/vm.go
Outdated
| // Shutdown the VM. | ||
| // Wait until a VM reaches the desired state. An error is returned if the VM doesn't reach the | ||
| // desired state within the given timeout. | ||
| func vmWaitState(ctx context.Context, vmAPI *vms.Client, state string, timeout int) diag.Diagnostics { |
There was a problem hiding this comment.
We can probably reuse this one?
There was a problem hiding this comment.
Oh! I hadn't seen it. Thanks for catching that.
bpg
approved these changes
Aug 21, 2023
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Proxmox cluster receives a shutdown or startup command for a VM that is declared as a HA resource, it doesn't honour the request immediately. Instead the API call returns and the state changes later, at the HA manager's discretion. Because of that, the plugin could end up trying to effect inappropriate changes on a VM that wasn't in the expected state.
This PR adds a wait loop after both startup and shutdown commands in order to ensure that the state is what we expect it to be.
Contributor's Note
Please mark the following items with an [x] if they apply to your PR.
Leave the [ ] if they are not applicable, or if you have not completed the item.
/docsfor any user-facing features or additions./examplesfor any new or updated resources / data sources.make examplesto verify that the change works as expected.Community Note
Closes #507