feat(vm): add 'path_in_datastore' disk argument #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide access to actual in-datastore path to disk image, and experimental support for attaching other VM's disks or host devices. Signed-off-by: Oto Petřík <oto.petrik@gmail.com>
This was referenced Oct 7, 2023
Signed-off-by: Pavel Boldyrev <627562+bpg@users.noreply.github.com>
bpg
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Thanks a lot @otopetrik!
I've just added the same config to the example VM resources for acceptance testing.
LGTM! 🚀
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide access to actual in-datastore path to disk image, and experimental support for attaching other VM's disks or host devices.
Contributor's Note
/docsfor any user-facing features or additions./examplefor any new or updated resources / data sources.make exampleto verify that the change works as expected.Proof of Work
See added example in VM's docs and in example resource.
Deployed VM from the example resource:
Community Note
Closes #567