Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file): rename content type backup -> dump for backups #724

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

DanielHabenicht
Copy link
Contributor

@DanielHabenicht DanielHabenicht commented Nov 16, 2023

Contributor's Note

  • I have added / updated documentation in /docs for any user-facing features or additions.
  • I have added / updated templates in /example for any new or updated resources / data sources.
  • I have ran make example to verify that the change works as expected.

Proof of Work

This now matches with the folder used by proxmox for backups
Also update documentation to reflect the change.
see comment in #700 before merging.

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #700

This now matches with the folder used by proxmox for backups
Also update documentation to reflect the change

Signed-off-by: DanielHabenicht <daniel-habenicht@outlook.de>
@DanielHabenicht DanielHabenicht changed the title specify right content type for backups fix(provider): specify right content type for backups Nov 16, 2023
Copy link

conventional-commit-lint-gcf bot commented Nov 16, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@bpg bpg changed the title fix(provider): specify right content type for backups feat(file): rename content type backup -> dump for backups Nov 17, 2023
@bpg bpg added the automerge label Nov 17, 2023
Copy link
Owner

@bpg bpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @DanielHabenicht!

LGTM! 🚀

@bpg bpg merged commit 3280370 into bpg:main Nov 17, 2023
8 checks passed
@ghost ghost mentioned this pull request Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxmox_virtual_environment_file: backups content_type erroring on apply
2 participants