-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warnings thrown when using namespace xml #1319
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
You could also rename your diagram to |
Ah, that makes sense. Thank you, I'll do that next time. |
Can reproduce the issue. |
Upstream issue: bpmn-io/moddle-xml#50 |
Happy to take contributions that fix this issue. |
I have provided a PR which should fix this issue: bpmn-io/moddle-xml#51 |
I tested an adapted version of @onlineandy 's fix for moddle-xml v 8.0.7 in combination with bpmn-js, worked great! |
Upstream issue bpmn-io/moddle-xml#50 fixed. We'll cut patch releases of the required libraries. In the mean time, you may:
...to get your bpmn-js version fixed. |
Fixed in bpmn-js@7.0.1 |
Describe the Bug
When importing a diagram that uses the namespace xmlns:xml without explicitly declaring it warnings are thrown.
My understanding so far was that this namespace should be included by default in all xml files.
This issue is coming from running tests for the upcoming bpmn miwg demo.
Fixtures
Advertise_job_vacancy_xmlns.zip (updated link)
Steps to Reproduce
Adding xmlns:xml="http://www.w3.org/XML/1998/namespace" to the definitions removes these warnings.
Expected Behavior
As far as I understand it the standard xml namespace should be included by default in all xmls. Thus, no warnings should be shown if it is not explicitly named in the definitions.
Environment
Depends on bpmn-io/moddle-xml#50
The text was updated successfully, but these errors were encountered: