Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings thrown when using namespace xml #1319

Closed
ChrisSchoe opened this issue Apr 28, 2020 · 11 comments
Closed

Warnings thrown when using namespace xml #1319

ChrisSchoe opened this issue Apr 28, 2020 · 11 comments
Assignees
Labels
bug Something isn't working miwg Tracks BPMN compatibility issues pr welcome We rely on a community contribution to improve this.

Comments

@ChrisSchoe
Copy link

ChrisSchoe commented Apr 28, 2020

Describe the Bug
When importing a diagram that uses the namespace xmlns:xml without explicitly declaring it warnings are thrown.
My understanding so far was that this namespace should be included by default in all xml files.

This issue is coming from running tests for the upcoming bpmn miwg demo.
Fixtures

Advertise_job_vacancy_xmlns.zip (updated link)

Steps to Reproduce

  • import the file
  • note the numerous warnings thrown due to the nested error "missing namespace for prefix "

Adding xmlns:xml="http://www.w3.org/XML/1998/namespace" to the definitions removes these warnings.

Expected Behavior

As far as I understand it the standard xml namespace should be included by default in all xmls. Thus, no warnings should be shown if it is not explicitly named in the definitions.

Environment

  • Browser FF 75
  • OS: Win 10
  • Library version: 6.4.2

Depends on bpmn-io/moddle-xml#50

@ChrisSchoe ChrisSchoe added the bug Something isn't working label Apr 28, 2020
@nikku

This comment has been minimized.

@nikku nikku added the help wanted Extra attention is needed label Apr 28, 2020
@ChrisSchoe

This comment has been minimized.

@nikku
Copy link
Member

nikku commented Apr 28, 2020

You could also rename your diagram to .bpmn.txt and upload it directly (without archiving).

@ChrisSchoe
Copy link
Author

Ah, that makes sense. Thank you, I'll do that next time.

@nikku nikku removed the help wanted Extra attention is needed label Apr 28, 2020
@nikku
Copy link
Member

nikku commented Apr 28, 2020

Can reproduce the issue.

@nikku
Copy link
Member

nikku commented Apr 28, 2020

Upstream issue: bpmn-io/moddle-xml#50

@nikku nikku added the miwg Tracks BPMN compatibility issues label Apr 28, 2020
@oguzeroglu oguzeroglu self-assigned this Apr 28, 2020
@nikku
Copy link
Member

nikku commented Apr 29, 2020

Happy to take contributions that fix this issue.

@nikku nikku added pr welcome We rely on a community contribution to improve this. backlog Queued in backlog labels Apr 29, 2020
@onlineandy
Copy link

I have provided a PR which should fix this issue: bpmn-io/moddle-xml#51

@ChrisSchoe
Copy link
Author

I tested an adapted version of @onlineandy 's fix for moddle-xml v 8.0.7 in combination with bpmn-js, worked great!

@nikku
Copy link
Member

nikku commented Jun 5, 2020

Upstream issue bpmn-io/moddle-xml#50 fixed.

We'll cut patch releases of the required libraries. In the mean time, you may:

npm update --depth=10 moddle-xml

...to get your bpmn-js version fixed.

@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Jun 5, 2020
@oguzeroglu
Copy link
Contributor

Fixed in bpmn-js@7.0.1

@bpmn-io-tasks bpmn-io-tasks bot removed the ready Ready to be worked on label Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working miwg Tracks BPMN compatibility issues pr welcome We rely on a community contribution to improve this.
Projects
None yet
Development

No branches or pull requests

4 participants