Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite loop in Auto-place after a BoundaryEvent in a corner #788

Closed
nboissel opened this issue May 3, 2018 · 2 comments
Closed

Infinite loop in Auto-place after a BoundaryEvent in a corner #788

nboissel opened this issue May 3, 2018 · 2 comments
Labels
bug Something isn't working modeling
Milestone
B25

Comments

@nboissel
Copy link

nboissel commented May 3, 2018

Expected Behavior

Auto-placement of element after BoundaryEvent.

Actual Behavior

Infinite loop caused by a NaN.

Steps to reproduce the Behavior

Infinite loop

Error seems to be in ./lib/features/auto-place/AutoPlaceUtil.js in L54, when orientation is set to 'top-right' or another corner, verticalDistances[orientation] returns NaN.
It then create an infinite loop.
@nikku nikku added bug Something isn't working modeling ready Ready to be worked on labels May 3, 2018
@nikku nikku added this to the B25 milestone May 3, 2018
@nikku
Copy link
Member

nikku commented May 3, 2018

Would you like to file a PR for this issue?

@nboissel nboissel mentioned this issue May 3, 2018
Closed
@ghost ghost added needs review Review pending and removed ready Ready to be worked on labels May 3, 2018
@nikku nikku closed this as completed in 9379aba May 4, 2018
@ghost ghost removed the needs review Review pending label May 4, 2018
@nikku
Copy link
Member

nikku commented May 4, 2018

Released as v1.3.1.

@nikku nikku reopened this May 4, 2018
@nikku nikku closed this as completed May 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working modeling
Projects
None yet
Milestone
B25
Development

No branches or pull requests
2 participants
@nikku @nboissel