Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color API not working #169

Closed
CaptnIglo opened this issue Oct 28, 2020 · 4 comments · Fixed by #171
Closed

Color API not working #169

CaptnIglo opened this issue Oct 28, 2020 · 4 comments · Fixed by #171
Assignees

Comments

@CaptnIglo
Copy link

Hello,
I tried to use the color API. The colors will be inserted into the xml, yet the colors are not displayed/rendered. I was not sure if the color API is meant to work. Would be great to get any feedback on that.

@jan-ladleif
Copy link
Member

Hi @CaptnIglo, thank you for your interest in chor-js! 🙂
Could you check whether your issue is the same as this one #152?
If so, that is a current limitation of the renderer, unfortunately.

@CaptnIglo
Copy link
Author

Hey @jan-ladleif , thank you for your fast reply. It seems like it is the same issue. Will colors be reintroduced in the future?

@jan-ladleif
Copy link
Member

@CaptnIglo Well, since it's been on our backlog for a while, I went ahead and implemented it, see the PR here: #171 🙂
Please feel free to comment, test it out, and make suggestions!

Otherwise, we'll have to do some more tests tomorrow, and will then publish a new release of chor-js in a few days.

@CaptnIglo
Copy link
Author

Hey, @jan-ladleif these are great news. Thank you very much for taking your time to implement this feature. I will try it out during the next days. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants