[CLOSED] Dark Mac

[core-ai-bot]

Issue by JeffryBooher
Tuesday Nov 12, 2013 at 20:23 GMT
Originally opened as adobe#380

---

FIXED

• [Dark Shell Mac] Slight window repositioning when going full screen on Mac adobe/brackets#5602
• [Dark Shell Mac] Secondary windows display standard title bar during transition from full screen adobe/brackets#5605

UTR

• [Dark Shell Mac] 10.9 only: Brackets window doesn't resize when exiting Full Screen mode on secondary monitor adobe/brackets#5796

BOLO

• Intermittently going full screen will produce a blank screen. I thought this was fixed with a few cocoa calls to unhide and activate the app before going full screen. If you click on the brackets dock icon the appear will appear after going full screen. At that point it is no longer a problem. But the problem is intermittent. I had 10-15 successful launches to full screen without this problem so hopefully the additional NSView setNeedsDisplay:YES call after entering full screen mode fixed it but it's hard to say. I'd say since there is a work-around then let's roll with it and, if it's reproducible, then file a bug and we'll address it in the usual way. I don't think it's a show stopper unless it reproduces with great frequency.

---

JeffryBooher included the following code: https://github.com/adobe/brackets-shell/pull/380/commits

[core-ai-bot]

Comment by jasonsanjose
Wednesday Nov 13, 2013 at 02:17 GMT

---

I did a high level review, but I can't say much about the Cocoa usage.

[core-ai-bot]

Comment by bobeast
Wednesday Nov 13, 2013 at 19:04 GMT

---

Once the dust settles, I highly recommend refactoring such that each class gets its own file pair, as opposed to placing multiple classes in a single file.

[core-ai-bot]

Comment by redmunds
Thursday Nov 14, 2013 at 04:50 GMT

---

Merging.