[CLOSED] Substitute for #124

[core-ai-bot]

Issue by DennisKehrig
Monday Oct 08, 2012 at 22:46 GMT
Originally opened as adobe#125

---

Modified fix for adobe/brackets#1147 (and probably adobe/brackets#1689) based on Glenn's work in #120.

Makes sure that the default size definitely fits the available space. It will only be used on the first launch of Brackets. Subsequent launches use stored window size and position which is adjusted automatically by the OS.

---

DennisKehrig included the following code: https://github.com/adobe/brackets-shell/pull/125/commits

[core-ai-bot]

Comment by jasonsanjose
Tuesday Oct 09, 2012 at 16:22 GMT

---

Reviewing

[core-ai-bot]

Comment by jasonsanjose
Tuesday Oct 09, 2012 at 23:03 GMT

---

I wasn't able to reproduce adobe/brackets#1147 in the current master branch with Glenn's changes on my macbook air at 800x600. Is there another trick to get it to reproduce without commenting those lines out and recompiling?

[core-ai-bot]

Comment by jasonsanjose
Tuesday Oct 09, 2012 at 23:13 GMT

---

Looks good. Just wanted to confirm the existing bug with @DennisKehrig.

[core-ai-bot]

Comment by DennisKehrig
Wednesday Oct 10, 2012 at 15:32 GMT

---

You can try deleting /Users/<username>/Library/Preferences/io.brackets.appshell.plist
I also deleted io.brackets.appshell.plist.90T0uZH and io.brackets.appshell.plist.lockfile in the same directory, not sure that makes a difference.
I could reproduce the bug this way with daily build 2012-10-10_02-00-18.

[core-ai-bot]

Comment by jasonsanjose
Wednesday Oct 10, 2012 at 18:42 GMT

---

Thanks @DennisKehrig. I was able to confirm the bug in the existing build at 800x600 and I also confirmed your fix. Merging.