Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLOSED] Don't let ESC key bubble in CodeHintList. Fixes #12799 #10903

Open
core-ai-bot opened this issue Aug 30, 2021 · 1 comment
Open

[CLOSED] Don't let ESC key bubble in CodeHintList. Fixes #12799 #10903

core-ai-bot opened this issue Aug 30, 2021 · 1 comment

Comments

@core-ai-bot
Copy link
Member

Issue by petetnt
Thursday Sep 22, 2016 at 18:21 GMT
Originally opened as adobe/brackets#12802

This PR fixes #12799 by handling ESC key presses differently from other actions that close the CodeHintList popup. event.stopImmediatePropagation is used to prevent the stop event from bubbling up.

cc@adityapaturi who reported the original issue.

Signed-off-by: petetnt pete.a.nykanen@gmail.com

petetnt included the following code: https://github.com/adobe/brackets/pull/12802/commits
@core-ai-bot
Copy link
Member Author

Comment by ficristo
Friday Sep 23, 2016 at 16:49 GMT

/cc@bmax too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@core-ai-bot