[CLOSED] Fix box model regression (transform)

[core-ai-bot]

Issue by Worie
Friday May 05, 2017 at 17:59 GMT
Originally opened as adobe/brackets#13357

---

Hi. In my recent commit adobe/brackets@ad915c7 for whatever reason I've removed a piece of code that made showing the box-model of transformed elements appear OK. I must have discarded the wrong hunk and did not refresh Brackets afterwards, so I didn't see it was broken. I'm very sorry for that.

This PR fixes this regression. However, we should consider visual testing to this feature to prevent such cases #13356 .

For now, could you ensure that it looks good for transformed elements, too (with or without borders, etc). I have tested it, but as you can see you can never be too cautios.

---

Worie included the following code: https://github.com/adobe/brackets/pull/13357/commits

[core-ai-bot]

Comment by petetnt
Saturday May 06, 2017 at 11:19 GMT

---

Meanwhile visual tests you could write a test project that showcases the possible options too 🤔 I think I reviewed that commit, sorry for not catching it myself.

[core-ai-bot]

Comment by Worie
Wednesday May 24, 2017 at 17:20 GMT

---

What about this one? Shall we merge it? There's no reason to keep it hanging, as the master still has broken version of RemoteFunctions.js.

I remember about the showcases with the options but I'm quite busy recently, so it'll have to wait.

[core-ai-bot]

Comment by petetnt
Wednesday May 24, 2017 at 17:28 GMT

---

Thanks@Worie