Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App layout is laggy when the window is being resized #12305

Open
core-ai-bot opened this issue Aug 31, 2021 · 6 comments
Open

App layout is laggy when the window is being resized #12305

core-ai-bot opened this issue Aug 31, 2021 · 6 comments

Comments

@core-ai-bot
Copy link
Member

Issue by larz0
Thursday Jun 06, 2013 at 20:39 GMT
Originally opened as adobe/brackets#4128


See Reflow for comparison. I spoke to Anirudh of Reflow and he said it took them awhile to get Reflow into that state.

They did benchmarked some perf stuff and found that taking out heavy assets and resize listeners helped them smooth out resizing.

To reproduce:

  1. Rename extensions folder to isolate the issue
  2. Expand Brackets /src folder
  3. Resize the window

Actual result:

  • Text glitches in the project panel
  • Layout is slightly laggy on edges

Expected result:

  • See Reflow CC (:pray:@anirudhsasikumar)
@core-ai-bot
Copy link
Member Author

Comment by jasonsanjose
Friday Jun 07, 2013 at 21:21 GMT


Reviewed. Medium priority to@jasonsanjose.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Friday Jun 07, 2013 at 21:26 GMT


@jasonsanjose this is slightly better now without any extensions installed.

@core-ai-bot
Copy link
Member Author

Comment by JeffryBooher
Friday Aug 16, 2013 at 19:37 GMT


@larz0 Is this worse with the new CEF build (Sprint 30 daily)? or are you seing this with Sprint 29 build? Corey posted something yesterday about serious redraw flicker due to resize and performance in CEF 1547 especially on Retina.

@core-ai-bot
Copy link
Member Author

Comment by larz0
Friday Aug 16, 2013 at 19:45 GMT


@JeffryBooher just tried the new CEF build and it's about the same. It's quite noticeable when you resize the window with the extension manager open.

@core-ai-bot
Copy link
Member Author

Comment by njx
Friday Aug 16, 2013 at 19:46 GMT


The resize performance doesn't seem significantly worse to me in the newest CEF (it was always bad :)), but the file tree redraw issue does look new--I don't recall seeing that before. I wonder if that's just a separate issue.

@core-ai-bot
Copy link
Member Author

Comment by peterflynn
Friday Aug 16, 2013 at 20:18 GMT


Fwiw, we will probably always have worse resize performance than Reflow (or most other HTML layouts, for that matter) because CodeMirror needs to actively do JS work on resize -- rather than letting browser-native layout take care of everything.

We could try to be clever and, for example, not fully refresh CodeMirror until the resize has crossed the boundaries of the extra-rendered-lines buffer that CodeMirror has available. That would not eliminate the lag from CM resizing, but it might possibly reduce it a whole lot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant